tests(dojo): break out langgraph platform tests into typescript and python #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
mme,
ranst91,
ataibarkai,
maxkorp and
NathanTarbert
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the LangGraph platform tests by separating Python and TypeScript tests into distinct test suites and creating dedicated TypeScript test files for LangGraph features.
- Created seven new TypeScript test files under
langgraphJSTestsdirectory covering various LangGraph features - Modified CI workflow to split LangGraph tests into separate Python and TypeScript test suites
- Organized tests by feature domains like tool-based UI, subgraphs, shared state, predictive updates, and human-in-the-loop
Reviewed Changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| toolBasedGenUIPage.spec.ts | New TypeScript tests for haiku generation feature |
| subgraphsPage.spec.ts | New TypeScript tests for multi-agent travel planning with supervisor coordination |
| sharedStatePage.spec.ts | New TypeScript tests for shared state between UI and chat components |
| predictiveStateUpdatePage.spec.ts | New TypeScript tests for predictive state updates with approval/rejection flows |
| humanInTheLoopPage.spec.ts | New TypeScript tests for human-in-the-loop planning workflows |
| agenticGenUI.spec.ts | New TypeScript tests for agentic generative UI features |
| agenticChatPage.spec.ts | New TypeScript tests for conversational chat with memory and background changes |
| dojo-e2e.yml | CI workflow changes to separate LangGraph Python and TypeScript test suites |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // FEATURE TEST: Test interrupt pause behavior - flow shouldn't auto-proceed | ||
| await page.waitForTimeout(3000); | ||
| // await expect(page.getByText(/hotel.*options|accommodation|Zephyr|Ritz-Carlton|Hotel Zoe/i)).not.toBeVisible(); |
There was a problem hiding this comment.
This commented-out assertion should be removed or properly implemented. Commented code reduces maintainability and creates confusion about the intended behavior.
Suggested change
| // await expect(page.getByText(/hotel.*options|accommodation|Zephyr|Ritz-Carlton|Hotel Zoe/i)).not.toBeVisible(); | |
| await expect(page.getByText(/hotel.*options|accommodation|Zephyr|Ritz-Carlton|Hotel Zoe/i)).not.toBeVisible(); |
Copilot uses AI. Check for mistakes.
…ython Signed-off-by: Tyler Slaton <[email protected]>
tylerslaton
force-pushed
the
tyler/lgjs-tests
branch
from
9f15f76 to
e800aa9
Compare
…i for lgts Signed-off-by: Tyler Slaton <[email protected]>
Signed-off-by: Tyler Slaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.